Nicholas Wilson

moved to `dlang/installer`. Presumably https://github.com/dlang/installer/blob/master/windows/d2-installer.nsi is the file that the installer is created from. What is the exact version of VS you have installed? What is the exact error message...

Thanks, offending code seems to be at https://github.com/dlang/installer/blob/master/windows/d2-installer.nsi#L384 (and also a suggestion to download version of VS2022 https://github.com/dlang/installer/blob/master/windows/d2-installer.nsi#L341). I don't speak NSIS, but I don't think that should be too...

Rikki linked me to https://github.com/microsoft/vswhere which we should probably be using instead of all this.

ping @rainers could you take a look at this?

No, they are all private (and most of them are `extern(D)`

Also did you mean to close this?

That looks like you messed up the token passed to en `error` somewhere, but it is _very strange_ that it only happens on a few platforms. Will take a look...

Looking good! You will need to update ` dmd/compiler/src/tests/cxxfrontend.cc`: ``` home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc: In member function ‘virtual void MiniGlueVisitor::visit(TypeStruct*)’: /home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc:795:35: error: ‘class AttribDeclaration’ has no member named ‘include’ 795 | (void)attrib->include(NULL); |...

Well the merge conflicts are beyond repair, so I'm doing that regardless: https://github.com/dlang/dmd/pull/16969 Keeping this around for the diff though, will close once the pieces of it have been merged.

> Still trying to invoke cl.exe... strange? is it not using `cl` for preprocessing? Does it do the same if you run `cl` with whatever the equivalent of `-E` is...