dlang
move `determineSize`/`finalizeSize` to `dsymbolsem.d`
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + dmd#16952"
I would suggest breaking this into smaller PRs. It's easier to review, to spot the bugs when the pipeline is failing and also diminishes the scope of @ibuclaw 's reverts.
Well the merge conflicts are beyond repair, so I'm doing that regardless: https://github.com/dlang/dmd/pull/16969
Keeping this around for the diff though, will close once the pieces of it have been merged.