Nicholas Wilson
Nicholas Wilson
Yes, tbf, I just copied almost exactly what Simen wrote.
I'm not particularly fussed either way.
> So turn it off and see what breaks. This should eventually go under a `version` that we can set defaults on
Nothing, as Buildkite is not required to pass to pull. You should double-check that the benchmark is the _only_ failure though.
Ack, waiting on https://github.com/dlang/phobos/pull/7011 for green tests.
Can you please rebase this so the circle error goes away?
Hmm vibe.d still fails.
`std/internal/math/gammafunction.d(569): [unittest] unittest failure` `assert(logGamma(-50.2L) == log(fabs(gamma(-50.2L))));` e: relaxed to `assert(feqrel(logGamma(-50.2L),log(fabs(gamma(-50.2L)))) > real.mant_dig-2);`
``` std\internal\math\gammafunction.d(1045): [unittest] unittest failure assert(feqrel(betaIncompleteInv(5, 10, 0.2000002972865658842L), 0.229121208190918L) >= real.mant_dig - 3); ```
actually could you do me a favour and upstream the relaxations