Nicholas Wilson

Results 297 comments of Nicholas Wilson

it is stuck. We should have this but it is not a high priority

Dependent PR has been merged, what else is needed for this to go though?

> +5,406 −5,490 Looks like it did _something_, exactly what Im not quite sure.

Again, the header was invalid before, this is not "more invalid", it is less invalid than before. To be sure, it is definitely still _very invalid_, but this is an...

> Is there any way we can, at least, partially test the output of dtoh with some real life tests? There are some dtoh tests under `compilable/` but they are......

The heck is wrong with Circle here?

... https://github.com/dlang/dmd/pull/15947 how did that not fail spectacularly well before this PR???

Buildkite failures: - [ ] `snazzy-d/sdc`: [src/source/location.d(230,51): Error: undefined identifier `isMixin`](https://github.com/snazzy-d/sdc/blob/master/src/source/location.d#L168) - [ ] `ldc-developers/ldc`: same frontend issue as https://github.com/dlang/dmd/pull/15947 - [ ] `atilaneves/unit-threaded`: some forward referencing error.

@kinke what's the best way to get https://github.com/dlang/dmd/pull/15947 into LDC for this PR: cherry pick it? wait until we merge upstream? cc @ibuclaw this will affect GDC too

I appreciate the sentiment. A couple of notes: * the original error message tells me what linker is being used (if not by name (ld, lld), then by format of...