dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Make `global.param.{obj,lib}` an `Output`

Open thewilsonator opened this issue 2 years ago • 4 comments

Follows up on https://github.com/dlang/dmd/pull/14048 https://github.com/dlang/dmd/pull/12617

thewilsonator avatar Oct 03 '23 09:10 thewilsonator

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15647"

dlang-bot avatar Oct 03 '23 09:10 dlang-bot

Hmm this looks to have stuffed up linking in the standard library by default.

thewilsonator avatar Oct 03 '23 14:10 thewilsonator

@thewilsonator are you still working on this?

RazvanN7 avatar Jan 10 '24 12:01 RazvanN7

it is stuck. We should have this but it is not a high priority

thewilsonator avatar Jan 10 '24 12:01 thewilsonator