weipeng

Results 25 comments of weipeng

Hi, could you please clarify if you intend to add an enum to the macro, or if you're suggesting that the macro should be modified to support enums? Additional details...

> Hello @chaokunyang , I am Forcha Pearl from Cameroon . I am very good bit manipulation, endianess, encoding DataStructures and Algorithm. I also experienced with Java, python and javascript....

> have you picked up the Add rust test suites? I want to try Add rust test suites > @chaokunyang @wangweipeng2 Hello, have you picked up the Add rust test...

I've been waiting for some feedback on this PR, could someone take a look at this ? I'd appreciate any feedback you can provide. Thanks! @nodejs-github-bot

> Actually, I see that @joyeecheung already left a number of helpful comments on the original ticket. Moving this to the `v8` API makes a bit more sense, because it...

> Removing the 'changes requested' marker but this should have better documentation and, ideally, a use case that explains why we're adding this to the API Could you please review...

Looks like a flaky test. Needs a re-run I think. @nodejs-github-bot

Needs a re-run again, another test has failed this time. @nodejs-github-bot

The CI checks have passed, and your review has been addressed. Would it be possible to merge this PR now? Thank you for your great support!