weipeng

Results 25 comments of weipeng

@nodejs-github-bot Needs a re-run please, I have corrected the documentation.

@addaleax I've updated the PR based on your feedback. Could you please take a moment to check if it's ready to merge or if there's anything else that needs attention?

> There is still no clear use case for this. The OP mentions `ucs2Write` and `latin1WriteStatic` but these are internal methods so cannot be used as arguments to add this...

> Can you please answer @addaleax's question ? [#56147 (review)](https://github.com/nodejs/node/pull/56147#pullrequestreview-2524315487) Following her suggestion in the comment https://github.com/nodejs/node/pull/56147#discussion_r1898670399, I have written an example in the documentation to explain why we need...

> @theweipeng Sure, but to be clear, I wasn't asking for a complex example in the documentation (because complex documentation can easily distract from the important bit – what the...

> @theweipeng I was comparing the current version against always using UTF16-LE, to be clear, not against UTF-8. Otherwise I don't think you end up with a fair comparison (UTF-8...

> > @theweipeng I was comparing the current version against always using UTF16-LE, to be clear, not against UTF-8. Otherwise I don't think you end up with a fair comparison...

If there’s anything else I can do to help move this forward, please let me know. I’m more than happy to make any additional changes or provide further details.

> Hello @theweipeng , please can shed some light here. Thanks for your great work on the MetaString. The main goal of Forward/Backward compatibility is to generate code at runtime....

Please refer to the document at `https://fury.apache.org/docs/specification/fury_xlang_serialization_spec#type-meta`. Using the 'stringify' method to encode the description is incorrect