Wenzhi Feng comments

Results 87 comments of


                                            Wenzhi Feng

[fix] [broker] fix incorrect delete sub when lastActive do not update.

> > > why do we update the cursor when every check ? > > > > > > If the consumer do not commit the offset for any reason,...

[fix] [broker] fix incorrect delete sub when lastActive do not update.

> @thetumbled Could you add a test for this case? Thanks I push a new commit to add the test code, PTAL, thanks.

[fix] [broker] fix incorrect delete sub when lastActive do not update.

PTAL, thanks. @dao-jun @lhotari @Technoboy- @poorbarcode @coderzc @codelipenghui

[fix] [broker] fix incorrect delete sub when lastActive do not update.

closed as https://github.com/apache/pulsar/pull/22794 has been merged.

[improve][pip] PIP-347: add role field in consumer's stat

> @thetumbled Please resolve conflicts Done, thank you.

[improve][pip] PIP-347: add role field in consumer's stat

Could you help to review? thank you. @lhotari @Technoboy- @codelipenghui

[improve][pip] PIP-347: add role field in consumer's stat

/pulsarbot rerun-failure-checks

[improve][pip] PIP-347: add role field in consumer's stat

/pulsarbot rerun-failure-checks

[fix] [broker] fix subscribe a non-existent cluster/namespace/topic.

PTAL, thanks. @lhotari @dao-jun @BewareMyPower @poorbarcode

[Feature][Txn] Support for commit idempotency.

> Please keep this PR separate so that it can help committers review it. thanks :) fixed, this is the solely PR related to PIP-255. https://github.com/apache/pulsar/issues/19744