Wenzhi Feng
PTAL, thanks. @BewareMyPower @poorbarcode @codelipenghui @liangyepianzhou
> Could you add a test for it? Added, PTAL, thanks.
> @thetumbled You need to add a test related to transaction, right? `testUpdateLastDataMessagePublishedTimestampForTransactionalPublish()`
Hi everyone, i have add the end-to-end test code `TransactionalReplicateSubscriptionTest` to reproduce the bug `replicated subscriptions not work for transactional messages`, you can add it alone to master branch to...
> Please check the typo "maker", should be "marker" fixed, thanks.
> it looks if `transactionCoordinatorEnabled=false` and publish normal msgs only to the topic, `lastDataMessagePublishedTimestamp` will not update. Thanks for review, i have updated the code, PTAL.
> I just don't understand, it seems ReplicatorSubscriptionController only snapshots `ledger.lastPosition`, why do we update `lastDataMessagePublishedTimestamp` after `maxReadPosition` moved? We may need to have a discussion about which time point...
> > * update `lastDataMessagePublishedTimestamp` when the max position move forward. > > this seems to make sense. assuming that "when the max position moves forward", there are more messages...
PTAL, thanks. @lhotari @codelipenghui @liangyepianzhou @dao-jun @Technoboy-
/pulsarbot rerun-failure-checks