pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][pip] PIP-347: add role field in consumer's stat

Open thetumbled opened this issue 1 year ago • 1 comments

Motivation

By setting config allowAutoSubscriptionCreation=true, we allow user to create subscriptions automatically if user have the consume permission. We have a strong need to trace back the owner of a specific subscription, but currently there is no such way to achieve that.

Modifications

Add field role in the stats response.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [x] doc-required
  • [ ] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/thetumbled/pulsar/pull/48

thetumbled avatar Apr 23 '24 04:04 thetumbled

PTAL, thanks. @lhotari @codelipenghui @BewareMyPower @Technoboy- @dao-jun @poorbarcode

thetumbled avatar Apr 23 '24 04:04 thetumbled

@thetumbled Please resolve conflicts

dao-jun avatar May 14 '24 11:05 dao-jun

@thetumbled Please resolve conflicts

Done, thank you.

thetumbled avatar May 14 '24 12:05 thetumbled

Could you help to review? thank you. @lhotari @Technoboy- @codelipenghui

thetumbled avatar May 15 '24 02:05 thetumbled

/pulsarbot rerun-failure-checks

thetumbled avatar May 15 '24 06:05 thetumbled

/pulsarbot rerun-failure-checks

thetumbled avatar May 15 '24 11:05 thetumbled