Ian Tommins

Picking this up

@morcs Check out #1899, which I've just opened a PR for

I am also seeing this warning (only occurs immediately after clearing cache) > The spaceless tag in "@ComurImage/Form/fields.html.twig" at line 4 is deprecated since Twig 2.7, use the "spaceless" filter...

Third deprecation: > User Deprecated: Using the "Twig_Extension_GlobalsInterface" class is deprecated since Twig version 2.7, use "Twig\Extension\GlobalsInterface" instead. The namespaced version has been available since twig 1.34 and 2.4, so...

Fourth deprecation: > User Deprecated: Referencing controllers with ComurImageBundle:Upload:getLibraryImages is deprecated since Symfony 4.1, use "Comur\ImageBundle\Controller\UploadController::getLibraryImagesAction" instead. Further documentation is at https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-bundle-notation The suggested fix is supported in Symfony 3.4,...

Fifth deprecation: > User Deprecated: The "Comur\ImageBundle\Controller\UploadController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead. This is documented at https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-bundle-notation The important difference between these two...

That's all the deprecation messages that I can see. These changes are working well for me in Symfony 4.4 and based on the documentation should work with the older versions...

Use of Symfony\Component\Translation\TranslatorInterface prevents Symfony 5 working at all when the bundle is enabled. Its replacement was only introduced in Symfony 4.2, so I've had to make that the minimum...

@comur Thanks for the response. No worries, I know what it's like to be an open source maintainer. I've merged master into my branch which includes the removal of twig...

With that last commit this is now working for me on Symfony 5 and twig 3. I have tested uploading, cropping and using an existing image and everything worked well.