Jon Roberts

Results 20 comments of Jon Roberts

I also made an attempt in PR #760 , check it out if you have a chance. I did it from scratch, going to look through this for bits I...

I'm working on this, and I think I'm almost done. Going to open a draft PR, comment on the other PRs.

I also made an attempt in draft PR #760 , check it out if you have a chance. I did it from scratch, going to look through this for bits...

I looked at this a bit during Case Contact Form Overhaul - current code is: ```ruby def get_contact_types case_contact_types = ContactType.includes(:contact_type_group) .joins(:casa_case_contact_types) .active .where(casa_case_contact_types: {casa_case_id: @casa_cases.pluck(:id)}) if case_contact_types.present? case_contact_types else...

Offense count by file ### `BYPASS_RUBOCOP_TODO=1 bundle exec rubocop --format worst ` ```sh BYPASS_RUBOCOP_TODO=1 bundle exec rubocop --format worst 115 spec/models/volunteer_spec.rb 100 spec/system/casa_cases/edit_spec.rb 81 spec/policies/case_contact_policy_spec.rb 72 spec/policies/casa_case_policy_spec.rb 65 spec/requests/users_spec.rb 55...

> We use standardrb so we don't need to configure it. This seems worse. @compwron Zero config is nice, but there are a few tradeoffs, imo... `standard-rails` disables the `default_scope`...

Dropping in favor of #6120 as standard can inherit some rubocop config, and therefore avoids changes to CI setup etc...

I have signed the CLA!

@etiennebarrie what do you think of this readme change? Sorry for the ping, this has been up for 2 weeks.

Resolved in #6048 - form is single page now.