casa icon indicating copy to clipboard operation
casa copied to clipboard

add checkboxes to skip later pages of the case contact form

Open elasticspoon opened this issue 1 year ago • 7 comments

What type(s) of user does this feature affect?

  • supervisors
  • admins
  • volunteers

Description

The main flow of our application is case contact creation (/case_contacts/:id/form), we want this process to be as quick and seamless for volunteers are possible.

Volunteers have stated to us that they have to perform a lot of extra clicks when submitting a case contact but they don't have notes or driving info to enter.

Lets add some buttons that will allow the volunteers to optionally skip past those pages in the form.

Image

Criteria for Completion

  • [ ] On the first page of the form add toggles to skip notes and expenses
  • [ ] On the notes page add a toggle to skip expenses
  • [ ] Make sure the expenses toggle does not show if the users can't set expenses
  • [ ] We have a jsonb field metadata on each case contact. Store whether a user chose to use those buttons or not in the json metadata so we can measure how useful these buttons are later.

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

elasticspoon avatar Jul 17 '24 19:07 elasticspoon

I've taken a look at this one and have got some buttons added that are passing their status up to the controller on form submit.

Screenshot 2024-08-08 at 6 22 38 PM

I'd be happy to take this one to the finish line if you'd like to assign it to me. Definitely have a few questions if so. Can transfer these to a draft PR if you'd like.

  1. Would you prefer we override the next step at the controller level or would we rather dive into the wizard and make some modifications there? Still wrapping my head around that gem and how it works
  2. Would you like to add some javascript that changes the submit button component text on the client side to "Submit" whenever all relevant skips are checked?
  3. Are we using any tooling to auto format ERB files because the tool I'm using is completely reformatting the details.html.erb file and I would feel bad committing all that if its not preferred or we have another solution

jamesh38 avatar Aug 08 '24 22:08 jamesh38

I'd be happy to take this one to the finish line if you'd like to assign it to me. Definitely have a few questions if so. Can transfer these to a draft PR if you'd like.

Sound good @jamesh38

1. Would you prefer we override the next step at the controller level or would we rather dive into the wizard and make some modifications there? Still wrapping my head around that gem and how it works

I believe you will have to do it at a controller level (I think most of the wizard related logic lives in the controllers and some in the CaseContact model). The wizard is an external gem so we can't really modify it.

2. Would you like to add some javascript that changes the submit button component text on the client side to "Submit" whenever all relevant skips are checked?

I would consider that a "nice to have" but its not required for the sake of the PR.

3. Are we using any tooling to auto format ERB files because the tool I'm using is completely reformatting the `details.html.erb` file and I would feel bad committing all that if its not preferred or we have another solution

We use erb_lint. You can lint the project running bin/lint. It would be preferred if you didn't commit significant formatting changes alongside behavior changes just because it makes it way harder to follow the changes in behavior.

elasticspoon avatar Aug 10 '24 20:08 elasticspoon

This issue has been inactive for 244 hours (10.17 days) and will be unassigned after 116 more hours (4.83 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Aug 21 '24 00:08 github-actions[bot]

Thanks @elasticspoon I'll be taking a look at this and finishing up this week.

jamesh38 avatar Aug 25 '24 18:08 jamesh38

This issue has been inactive for 246 hours (10.25 days) and will be unassigned after 114 more hours (4.75 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Sep 05 '24 00:09 github-actions[bot]

This issue has been inactive for 366 hours (15.25 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Sep 10 '24 00:09 github-actions[bot]

Resolved in #6048 - form is single page now.

thejonroberts avatar Oct 21 '24 18:10 thejonroberts

Life happened and I didn't finish this one apologies there folks. Are we good to close this then now if it's no longer relevant? @elasticspoon @thejonroberts

jamesh38 avatar Nov 10 '24 03:11 jamesh38