thejayps

In [proc.exit.universal](https://github.com/Ravenbrook/mps/blob/586336a7021c2276a3f798ad10e6e4ab5f438226/procedure/exit.universal.rst) the criteria .rates mentions "the optimum rates" which has no tag or reference. We should refer to where the optimum rates are defined and use a tag.

The [review procedure document](https://github.com/Ravenbrook/mps/blob/586336a7021c2276a3f798ad10e6e4ab5f438226/procedure/review.rst) describes 11 phases in section 4, one of which is phase.estimation. All phases except phase.request and phase.estimation have an associated procedure in section 5. These two...

This issue is a .imp.issue from brainstorming improvements in https://github.com/Ravenbrook/mps/pull/213. This issue is best described by the specific comments: https://github.com/Ravenbrook/mps/pull/213#pullrequestreview-1420973870 https://github.com/Ravenbrook/mps/pull/213#issuecomment-1544003201 https://github.com/Ravenbrook/mps/pull/213#issuecomment-1544023867

"Hash arrays" work lacks a specific testbench

4

#230 has no testbench. We discussed (@thejayps, @rptb1 and @UNAA008) during the preparation of the pull request that the testbench would be difficult to write, and decided to defer it...

mps_addr_object has no design

2

mps_addr_object violates rule.code.design

Transforms is estimated to contain more than 2 undiscovered major defects

2

Transforms (#214) is exiting review with an unusually high (3.3) number of estimated remaining Major defects. The defects are strongly suspected to be around the clarity of documentation and generalisation...

Design for "hash arrays" needs to clearer

1

This issue captures several defects/comments recorded during the review of #230: "M. https://github.com/Ravenbrook/mps/blob/branch/2023-05-31/hash-arrays/code/poolamc.c#L961-L962 "defer the size accounting" with what intention? (Could refer to design.mps.strategy section.) rule.generic.clear (Please see https://github.com/Ravenbrook/mps/issues/233#issuecomment-1580131391 when...

See https://github.com/Ravenbrook/mps/pull/214#issuecomment-1593155571 Checking guidance for each checking role should probably describe: - how to estimate how much work there is in total for the checker, and - how to estimate...

Documentation for mps_arena_postmortem does not indicate a requirement or a use case

1

The documentation for mps_arena_postmortem describes what it does, it does not describe why it was implemented, why you would want to use it, or indicate what sort of requirements it...

proc.review.edit assumes everything from proc.review.log is clear to the proc.review.role.editor

1

As a proc.review.role.editor I have found logging information to be unclear subsequent to proc.review.log, and during proc.review.edit. It is possible that aspects of logging comments met with rule.generic.clarity for me...