mps icon indicating copy to clipboard operation
mps copied to clipboard

Design for "hash arrays" needs to clearer

Open thejayps opened this issue 2 years ago • 1 comments

This issue captures several defects/comments recorded during the review of #230: "M. https://github.com/Ravenbrook/mps/blob/branch/2023-05-31/hash-arrays/code/poolamc.c#L961-L962 "defer the size accounting" with what intention? (Could refer to design.mps.strategy section.) rule.generic.clear (Please see https://github.com/Ravenbrook/mps/issues/233#issuecomment-1580131391 when editing this. RB 2023-05-07)" from https://github.com/Ravenbrook/mps/pull/230#pullrequestreview-1465077305

"My only comment is that the mechanism that setting MPS_KEY_AP_HASH_ARRAYS to true uses to not contribute to nursery space is not described. But perhaps it is correct that implementation details (which could change) are not discussed." from https://github.com/Ravenbrook/mps/pull/230#pullrequestreview-1465164108

"NQ. Is ramping documented? If so, we could mention in the manual that hash arrays are ramping." from https://github.com/Ravenbrook/mps/pull/230#issuecomment-1584351103

Also: "comment1: nice improvements to the documentation noted in the past could be relevant https://www.ravenbrook.com/project/mps/issue/job004109/" from https://github.com/Ravenbrook/mps/pull/230#issuecomment-1578733334 could be relevant if it still applies. This needs investigating.

thejayps avatar Jun 16 '23 12:06 thejayps

Assigned optional since having up-to-date and clear design for hash arrays will certainly help developers work on hash arrays in future, however the operation of hash arrays is probably simple enough that it could probably be inferred from the code successfully with some additional effort. Improving design for hash arrays would be of benefit and it's worth assigning resources to this.

thejayps avatar Jun 19 '23 13:06 thejayps