thejayps
thejayps
See also #72
It's essential to understand this properly.
Thanks for bringing this to our attention - it seems "added" is not used in the code but we'll double check that removing it is the correct fix
executing [proc.review.entry](https://github.com/Ravenbrook/mps/blob/branch/2023-01-19/review-procedure/procedure/review.rst#entry) with @UNAA008 Start time 1555 entry.express: looks low risk and @UNAA008 is available. [entry.universal](https://github.com/Ravenbrook/mps/blob/586336a7021c2276a3f798ad10e6e4ab5f438226/procedure/entry.universal.rst) applies, [entry.impl](https://github.com/Ravenbrook/mps/blob/586336a7021c2276a3f798ad10e6e4ab5f438226/procedure/entry.impl.rst) applies as rst is code. .source-approved the issue relating to this change...
Begin checking at 1646, resume at 1700 with 10 mins checking and small break
Stop Express review: major defect M1: In section 6: " git pull --rebase perforce then go back to testing (step 4). Alternatively, you could undo your merging work: git reset...
Attempt 2 at express review: Executing [proc.review.entry](https://github.com/Ravenbrook/mps/blob/0ee19fffed94be25fe409f07f6ac9f61a007de50/procedure/review.rst) Start time 1350 entry.express: still looks low risk, await @UNAA008 1400 @UNAA008 arrives Most comments relating to entry and planning here https://github.com/Ravenbrook/mps/pull/228#issuecomment-1779568832 remain...
Still needs analysis. Could be a solution to #269
now deemed essential to do the analysis required