Alexander Mohr

Results 302 comments of Alexander Mohr

wow awesome, will take a look if someone doesn't get to this before me

btw the idea for the tests, in regard to buckets is that each test gets a unique bucket, see https://github.com/aio-libs/aiobotocore/blob/master/tests/conftest.py#L30

~~It's been awhile but I think unfortunately moto shares global state across its services. Which is a good but also bad thing. Good because it allows cross service linkages (ex...

Actually ignore above rec for separate process per test. pytest-xdist already separates each test into a separate process

sorry for taking so long to review this, been super busy

nice, we were on pipenv, then got frustrated due to slowness/inability to resolve certain scenarios so moved to poetry, then found another blocking bug on it so switched back :)....

I agree too, please do. When bumping botocore make sure to diff botocore from old to new version and compare all the files aiobotocore overrides and apply changes as necessary,...

I think this is now done right? I saw flake complains if things aren't black compatible

@gmsantos oh I just meant it's working correctly, thank you!

that is indeed an interesting experiment. The performance will depend mostly on aiohttp, as that is what makes that actual calls. What version of aiohttp are you using? Your pip...