Alexander Mohr

Results 302 comments of Alexander Mohr

the new `StreamingBody.__enter__` + `StreamingBody.__exit__` in response.py need to be overridden to do the right thing.

missing change to `utils.py::InstanceMetadataFetcher::retrieve_iam_role_credentials`

btw I updated the recommended steps on that rst. Basically I usually diff old/new versions of botocore and apply changes, then diff aiobotocore to target version to ensure they match....

sorry for delay guys, things have just been nuts here

done in https://github.com/aio-libs/aiobotocore/pull/963

@terrycain thoughts?

we can't generate botocore from aiobotocore, botocore is the truth, aiobotocore is a third party enhancement

@terrycain exactly, lol I was looking at this: https://rushter.com/blog/python-bytecode-patch/ that referenced those modules, I need to spend some time to play around with it

I think it combined with the patch checker would be ok, but ya debugging would suk, unless we generate python code from the bytecode and add them as reference files,...