aiobotocore icon indicating copy to clipboard operation
aiobotocore copied to clipboard

Published 20 hours ago • verified publisher icon aio-libs

Adopt black

Open gmsantos opened this issue 2 years ago • 1 comments

I was looking to bump the botocore version and while I was comparing the changes in botocore, I noticed that botocore applied black at the codebase (https://github.com/boto/botocore/pull/2666).

Should this something aiobotocore plans to adopt? For me, it makes sense for consistency and makes it easier to compare the changes in the next botocore bumps. I am happy to do that at the same during I try to push a PR to bump botocore or as a full separate contribution.

gmsantos avatar Jul 01 '22 11:07 gmsantos

I agree too, please do. When bumping botocore make sure to diff botocore from old to new version and compare all the files aiobotocore overrides and apply changes as necessary, and update patch hashes.

thehesiod avatar Jul 01 '22 17:07 thehesiod

I think this is now done right? I saw flake complains if things aren't black compatible

thehesiod avatar Aug 25 '22 10:08 thehesiod

yes, it should be done @thehesiod. About flake complaining about black, I can take a look. The idea behind adding flake8-black and flake8-isort was to avoid that.

https://github.com/aio-libs/aiobotocore/pull/952/commits/5933acfb0569b74f66fe79046830c2d40f11b3d0#diff-230078d672f10d17463a8a6265cad825b790885898256a3365be90685caac58dR11-R12

gmsantos avatar Aug 25 '22 10:08 gmsantos

@gmsantos oh I just meant it's working correctly, thank you!

thehesiod avatar Aug 25 '22 16:08 thehesiod