aiobotocore
aiobotocore copied to clipboard
aio-libs
Bump botocore to 1.27.0
Description of Change
Continuation of #952, bump botocore to 1.27.0.
For a more straightforward review, here are the commits related to the bump only.
Checklist for All Submissions
- [x] I have added change info to CHANGES.rst
- [ ] If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
- [ ] Detailed description of issue
- [ ] Alternative methods considered (if any)
- [ ] How issue is being resolved
- [ ] How issue can be reproduced
- [ ] If this is providing a new feature (can be provided via link to issue with these details):
- [ ] Detailed description of new feature
- [ ] Why needed
- [ ] Alternatives methods considered (if any)
Checklist when updating botocore and/or aiohttp versions
- [x] I have read and followed CONTRIBUTING.rst
- [x] I have updated test_patches.py where/if appropriate (also check if no changes necessary)
- [x] I have ensured that the awscli/boto3 versions match the updated botocore version
View rendered .github/pull_request_template.md
This pull request introduces 1 alert when merging b0d4029fcd7c7e4c2c4a1221fed0561a5de7d79f into fe3d8476d31f995e7da404b02fb88967e4005275 - view on LGTM.com
new alerts:
- 1 for Missing call to `__init__` during object initialization
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request introduces 1 alert when merging 2d8e86c3a2fca592726a3e44a565bfa7142d9200 into fe3d8476d31f995e7da404b02fb88967e4005275 - view on LGTM.com
new alerts:
- 1 for Missing call to `__init__` during object initialization
@gmsantos needs merge/rebase from master and could you document the steps you performed to ensure we pulled all the relevant changes? Here are the steps I usually perform: https://github.com/aio-libs/aiobotocore/blob/master/CONTRIBUTING.rst#how-to-upgrade-botocore
Codecov Report
Merging #953 (9999791) into master (88a4309) will decrease coverage by
0.00%. The diff coverage is85.71%.
:exclamation: Current head 9999791 differs from pull request most recent head d7c0633. Consider uploading reports for the commit d7c0633 to get more accurate results
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
- Coverage 86.74% 86.74% -0.01%
==========================================
Files 55 55
Lines 5295 5302 +7
==========================================
+ Hits 4593 4599 +6
- Misses 702 703 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 86.74% <85.71%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| aiobotocore/credentials.py | 88.13% <ø> (ø) |
|
| aiobotocore/retries/bucket.py | 66.66% <ø> (ø) |
|
| aiobotocore/retries/standard.py | 97.22% <ø> (ø) |
|
| aiobotocore/waiter.py | 90.74% <ø> (ø) |
|
| tests/test_patches.py | 96.07% <ø> (ø) |
|
| aiobotocore/client.py | 85.86% <71.42%> (-0.25%) |
:arrow_down: |
| aiobotocore/endpoint.py | 96.66% <100.00%> (ø) |
|
| aiobotocore/utils.py | 76.66% <100.00%> (+0.26%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request introduces 1 alert when merging 6c0180f1d35b08bee7948d8f58b0d22aae057d3a into 88a43098b1194bf759581acc710ad5bdbdd99a96 - view on LGTM.com
new alerts:
- 1 for Missing call to `__init__` during object initialization
@gmsantos needs merge/rebase from master and could you document the steps you performed to ensure we pulled all the relevant changes? Here are the steps I usually perform: https://github.com/aio-libs/aiobotocore/blob/master/CONTRIBUTING.rst#how-to-upgrade-botocore
Sure @thehesiod, how I did was:
- first, I applied the same codestyle of botocore in aiobotocore (done in #952)
- from botocore I checkout both the previous release (1.24.21) and the target release (1.27.0)
- In the 1.24.21, I reapplied the same codestyle in botocore to reduce the noise from code diff
- After that, I used meld to do a 3-way comparison between:
- botocore 1.24.21 (patched with codestyle)
- aiobotocore (after #952)
- botocore 1.27.0
- I checked the changes in the source file and create a single commit for each one of the new changes from botocore 1.27.0
Apart from that, I bumped the setup.py and updated the patches files with the new expected hashes (I had to update practically all files impacted by code style changes).
To test in, I was able to install it on an Airflow deployment with astronomer-providers, and I didn't find any bug. Assuming that the automated tests are passing as well, it LGTM.
btw may want to bump again
That's my plan for the following contributions. Since my primary use for aiobotocore is as a dependency on astronomer-providers (see https://github.com/aio-libs/aiobotocore/issues/924), I was planning to bump to compatible botocore releases locked in Airflow constraints.
- Airflow 2.3.2 constraints locks botocore in 1.27.0 (this PR)
- Airflow 2.3.3 constraints locks botocore in 1.27.23
- Latest botocore version is 1.27.34
If that's okay, I can contribute with some PRs to the following two bumps, to 1.27.23 in aiobotocore v2.4.1 and 1.27.34 in aiobotocore v2.4.2
This pull request introduces 1 alert when merging 9999791ca85d2e4c4f897a3a1286bce3026acb4c into 88a43098b1194bf759581acc710ad5bdbdd99a96 - view on LGTM.com
new alerts:
- 1 for Missing call to `__init__` during object initialization
missing yield from change in eventstream.py::EventStream::_create_raw_event_generator
looks like str got erroneously turned into a tuple here: https://github.com/aio-libs/aiobotocore/blob/88a43098b1194bf759581acc710ad5bdbdd99a96/aiobotocore/paginate.py#L137
the new StreamingBody.__enter__ + StreamingBody.__exit__ in response.py need to be overridden to do the right thing.
missing change to utils.py::InstanceMetadataFetcher::retrieve_iam_role_credentials
btw I updated the recommended steps on that rst. Basically I usually diff old/new versions of botocore and apply changes, then diff aiobotocore to target version to ensure they match. Using Diffmerge it's then easy to apply changes from LHS to RHS at the end
This pull request introduces 1 alert when merging d7c063384000a84c6a90c78b508c211c677bb286 into f4dd2b47c58ad5ef66cdb73311a5a9eabaae932b - view on LGTM.com
new alerts:
- 1 for Missing call to `__init__` during object initialization
Hey guys, wondering if you have a sense of when this will be merged? Running into dependency conflicts that this bump would resolve 😄
@LOC333 maybe soon I can take a look at the PR comments. Busy weeks... can't promise though.
Take in mind that I'm not the maintainer, so if you are in a rush you can install from this unreleased branch. Again, no promises that will work as is for you.