Brian Nicholson

Results 4 issues of Brian Nicholson

`this[prior(this)]` compiles to `newData.child(data).val()` instead of the expected `newData.child(data.val()).val()`.

bug

Looking at the [Yelp categories](https://www.yelp.com/developers/documentation/v3/all_category_list), some categories have multiple parent categories. Example: "Art Galleries" falls under both "Arts & Entertainment" and "Shopping" (which will land the place in either Discover...

The `placesLock` we're using in `PlacesProvider` is error-prone: which methods should own the lock is unclear, and it's easy to deadlock in unexpected situations ([example](https://github.com/mozilla-mobile/prox/blob/eb86ad2227be304457fb526a041ab8ddb04af613/Prox/Prox/PlaceCarousel/PlaceCarouselViewController.swift#L449)). We should consider moving to...

`CompositePlaceProvider` sets fields from multiple places, but once a particular field has been set, it's ignored for others. For example, once we have photos from Yelp, TA/Wikipedia photos are dropped....