prox icon indicating copy to clipboard operation
prox copied to clipboard

Merge photos when combining sources

Open thebnich opened this issue 8 years ago • 2 comments

CompositePlaceProvider sets fields from multiple places, but once a particular field has been set, it's ignored for others. For example, once we have photos from Yelp, TA/Wikipedia photos are dropped.

We can make this better by merging photos and categories from multiple sources. As part of this, we'll want to de-dupe any values.

thebnich avatar Feb 08 '17 19:02 thebnich

Merging categories sounds complicated:

  • We have to filter our places on Yelp categories before we merge them
  • As you mention, de-dupe (we have to handle plurals, e.g. Bar -> Bars, as well as potentially concatenation, Bar -> Bar & Restaurant)

Unless the Yelp category list is a problem from the user perspective, I think we should just keep it simple and use the Yelp categories.

mcomella avatar Feb 09 '17 00:02 mcomella

Fair enough; morphing this to be for photos only.

thebnich avatar Feb 15 '17 02:02 thebnich