Thomas Christensen

Results 116 comments of Thomas Christensen

Looking at this now, I think it would've been nice to avoid a change as breaking as this, or to have used it as an occasion to fork and rename....

I'm happy to make a PR if @sjkelly are open to merging a change like this? It would just be adding an if case to use `X`, `Y`, and `Z`...

> On v1.11 and master, the gain seems to be smaller (in fact, might be measurement noise), at least on my machine. That's very cool! - I see the same,...

I continue to see a difference with the `GarbageVector` example above (on v1.11.3): ```jl julia> using Chairmarks julia> @be copy($v) julia> @be Base.copy($v) seconds=5 Benchmark: 127544 samples with 132 evaluations...

I'm not completely sure what you mean, but to clarify: I can reproduce this on Julia v1.6.2 installed via juliaup on Windows (and configured by setting no path for the...

This remains an issue and is quite the time-stealer for developing anything that depends on JuliaCall.jl/CondaPkg.jl. If there's any workarounds, I'd be grateful.

Yeah, transforming to this is something I've wanted to implement for a while but haven't yet. I think the main steps are the following: 1. transform to Niggli-reduced cell and...

Sure; PR'd in #1172.

Fixed by #1172.

For the doctest example of ` g = Graph(Edge.([1=>2, 2=>3, 3=>1, 4=>5, 5=>6, 6=>4, 7=>8]))`, `count_connected_components` is about twice as fast as `length∘connected_components` (179 ns vs. 290 ns). Using the...