Thomas Christensen

I'm wondering if an acceptable fix to this could be changing the `wnew` line to: ```jl wnew[e] = round(Int32, (c-cmin) / max(cmax-cmin, 1) * tmax) ``` EDIT: An alternative could...

Here's some code for visualizing the 2D situation, with some additional points included. ```jl function prep_bz_path(Rs) Gs = reciprocalbasis(Rs) cell = wignerseitz(Gs) kp = irrfbz_path(2, Rs) a, b = norm(Rs[1]),...

Hi Lorenzo, Sorry I forgot this - and thanks for making this PR. I think this is really nice and useful functionality. I wonder though, if it should have a...

A minor thing: what is the motivation for having multiple distinct colormaps? The stacking of them with some opacity feels a little arbitrary (i.e., one will partly occlude the other?).

This is very cool and would be really nice to have some form of this in Brillouin: expecting every use-case to necessarily be in the form of a standard lattice...

I think a good interface to solve this would be to have a function, e.g., in Bravais.jl, that takes a conventional (or primitive) direct lattice and a crystal system type...

> @thchr , I have one question on the relation of Brillouin.jl and seek-path. Are they different (independent) implementations of the same algorithm? Or do you call seek-path here? We...

That implementation is great - we should definitely add some form of this, I think. I have a few questions: - @mfherbst: what's the overlap of this implementation and what's...

As a side note, I mostly wrote Brillouin for research I do in photonic crystals (where we don't have a simple equivalent of "atom positions") so in my ideal world,...

Okay, makes sense. If you have the cycles, a PR would be very welcome👍!