Thomas Christensen

Results 97 comments of Thomas Christensen

An implementation with much better scaling is to start from the "bottom" instead, starting from small generator sizes rather than big: i.e., checking from small orders whether it is _possible_...

This currently has an implementation in KdotP.jl (https://github.com/thchr/KdotP.jl/blob/master/src/generator_indices.jl) that should be moved to Crystalline.jl: https://github.com/thchr/KdotP.jl/blob/0c38990c9ee63474c9b52e64458711657c12434f/src/generator_indices.jl#L6C1-L32C4

Hi Hongsheng, I was sure I had replied to this, but apparently not - sorry. Thanks for letting me know about your CrystKit package. Looks really neat and I enjoyed...

Typo, apologies 👍. Will edit for posterity :)

Hmm, the implementation hits a recursive loop because I didn't account for the possibility of the eltypes of the input not being subtypes of `Real`. The problematic bits are here:...

So, just to be more specific, the issue here is that ```jl T = eltype(eltype(Us)) # Quantity{Float64, 𝐋, Unitful.FreeUnits{(Å,), 𝐋, nothing}} T

For relevant literature that gives context to that formula, we can e.g. just think about how the "full" space group irreps are constructed from little group irreps. A good reference...

I think all "missing" k-points from Φ-Ω should have been added in #30, so we should now in principle be able to "cover" all of the BZ with operations gα...

There's a somewhat subtle point to add to bullet 1 in the original post, which is not obvious, I think. In particular, we say to pick a an element of...

This has been updated a while ago, just forgot to close this PR.