Tom Morris

Results 686 comments of Tom Morris

Sorry for the delayed reply. I didn't get notified of the comment a couple of weeks ago, so this didn't show up until Antonin replied over the weekend. > Having...

> I would like to get out of the current stalemate between this PR and https://github.com/OpenRefine/OpenRefine/pull/6146, to have one of them merged. To be clear, #6146 was never intended as...

Sorry for the delay. I was off sailing all last week. > If i understand your feedback, the ASK is to add additional support in the escape function to handle...

I messed up the specification here. I think using `urlpath` is misleading when it's actually escaping a URL path segment (the string between the slash (/) delimiters). ie a path...

Currently I think the login flow is triggered by the absence of a cookie, but I think the preferred/recommended way is to use an access failure to trigger it, which...

Actually, the problem is worse than described for this specific example because the MARC record actually includes the given name, but it got dropped during the import. The [edition](https://openlibrary.org/books/OL44269942M) which...

M. is the French equivalent of Mr. I had missed the fact that it was coded in the 100$c. Possible name forms from ```100 1 $aAnicet-Bourgeois,$cM.$q(Auguste),$d1806-1871.``` include: - M. Anicet-Bourgeois...

I'm getting very different times, perhaps because of network speed differences. We need to find a way to test this reproducibly so that we're not chasing our tails. We should...

> ... best case would be somehow differentiating the two in the English original or otherwise get it separated in the i18n files. It's more than just the best case,...

The file that imported correctly https://openlibrary.org/books/OL50976370M doesn't have a binary MRC file, just a MARC XML file. I'm not sure what conditions cause that in the processing pipeline. The additional...