openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Strange German translation

Open bitnapper opened this issue 1 year ago • 5 comments

image

The German translation „Rezension“ for „review“ seem very odd. The source „review“ is a verb and „Rezension“ is a noun. A direct translation would be „rezensieren“ but that would be unusual so maybe leave it „review“ (I guess even Germans who use the internet would understand that) or use „überprüfen“ or better „prüfen“.

bitnapper avatar Feb 07 '24 17:02 bitnapper

I'd be happy to do a quick fix for this once it's determined what the best replacement is!

rebecca-shoptaw avatar Feb 07 '24 20:02 rebecca-shoptaw

CC @justcomplaining , who's done a fantastic job making the site accessible in German :)

cdrini avatar Feb 07 '24 23:02 cdrini

I'm not sure in which contexts it appears. As I understand it, the word is used in different contexts, both for reviews of book as well as reviews of a change, is that correct?

In that case, translation is hard because "prüfen" ("check") is fine in Case of reviewing a change but not in case of reviewing a book, as that would rather be "rezensieren" (that's the correct term for a written literature review) or "bewerten" ("rate").

If it's actually like described above, best case would be somehow differentiating the two in the English original or otherwise get it separated in the i18n files.

The review dialog itself seems not to be i18n enabled or at least not added to the POT file yet.

justcomplaining avatar Feb 08 '24 18:02 justcomplaining

... best case would be somehow differentiating the two in the English original or otherwise get it separated in the i18n files.

It's more than just the best case, it's what's required by the translation guidelines. The button needs a separate ID like do_review or review_verb to distinguish it from the contexts where it's describing a review (or a rating). The IDs need to be assigned for separate semantic contexts, even if the English lexical form is the same.

That whole display is a mishmash of translated and untranslated components cf " opened vor 2 Studen by ". Since it's an admin interface, perhaps it should just be left untranslated until it can be done right.

tfmorris avatar Feb 08 '24 19:02 tfmorris

In that case I'd propose we keep the translation shown to most users (regarding book reviews) in the po file for now; probably not too many people with German UI working in the admin interface at the moment and that way outward-facing UI can stay usable? Once string IDs are defined, I'll then correct it to a proper one for the admin part as well.

If you don't agree feel free to remove this translation, the original "review" is not too bad, many Germans would still understand like @bitnapper said and the whole thing is not completely translated yet anyway :)

justcomplaining avatar Feb 08 '24 22:02 justcomplaining