Justus Winter

Installation does not honor --prefix when installing data

3

``` % python3 setup.py install --prefix=/tmp/gpgsync [...] running install_data copying share/gpgsync.desktop -> /usr/share/applications error: could not create '/usr/share/applications/gpgsync.desktop': Permission denied ``` Afaics this is because of the use of `sys.prefix`,...

Please avoid bundling libraries

14

genometools bundles quite a number of libraries: teythoon@europa /tmp/genometools-1.5.8 % ls -1 src/external bzip2-1.0.6/ cgilua-5.1.3/ expat-2.0.1/ lpeg-0.10.2/ lua-5.1.5/ luafilesystem-1.5.0/ md5-1.1.2/ samtools-0.1.18/ sqlite-3.8.7.1/ tre/ zlib-1.2.8/ This is generally frowned upon. See...

There are (at least) two reasons for that: - v5 OpenPGP certs will have only very limited interoperability with the current v4 certs. The way the design team pictures the...

Section on OpenPGP Based key data is too restrictive, hampers compatibility and encourages insecure practices

9

https://autocrypt.org/level1.html#openpgp-based-key-data says: > The keydata sent by an Autocrypt-enabled Level 1 MUA MUST consist of an OpenPGP “Transferable Public Key” containing exactly these five OpenPGP packets: > > a signing-capable...

argon2: The documentation claims that associated data (and keyid) are deprecated but they are not

6

Currently, the documentation https://docs.rs/argon2/0.3.2/argon2/struct.Params.html#method.data claims that: > This field is not longer part of the argon2 standard (see: https://github.com/P-H-C/phc-winner-argon2/pull/173), and should not be used for any non-legacy work. But I...

We have an object that implements io::Read, but needs to return failure::Errors during read operations. We therefore wrap failure::Errors into io::Error objects using failure::Compat. Now we (or our users) might...

Fixes #19.

Split kodos

4

This patch (meant to be applied upon my recent pull request #4) splits the main kodos file.

kodos uses pickle to load and save .kds files

2

kodos uses pickle to load and save .kds files despite the fact that http://docs.python.org/library/pickle.html clearly states: > Warning The pickle module is not intended to be secure against erroneous or...

So, here's the next round of cleanups including packaging cleanups, replacing getopt with optparse, making use of the logging module, cleaning up the imports and fixing various problems found by...