Nick Terrell
Nick Terrell
What version of gcc is this? I'd second updating your gcc version
> It seems we were told at some point that present wasn't a valid year, and that an actual date was necessary. That is not the latest guidance. We should...
Just `Copyright (c) Meta Platforms, Inc. and affiliates.` is fine. https://www.internalfb.com/intern/wiki/Open_Source/Licenses/
This is an interesting feature. I haven't looked at the code yet, but I don't see anything obviously wrong with the API you're describing. I like the requirement to acknowledge...
@eli-schwartz are you able to reproduce the error consistently?
> Because there will be a lot of sample data that repeats a certain data, but this data only appears once in this sample This is the intended use case...
Can you explain exactly what you want to do and why (an example may help)? I don't think that is what you want, but I can't be sure because I...
What is the motivation for this patch? I'm not against merging it, just wondering why you want it. Does this measurably improve performance on some compiler/architecture? Does this fix build...
Thanks for the PR @Hello71! Could you please separate it into two PRs: 1. Apply the fix from #2633 to legacy. I can merge this as soon as you put...
An example of your usage of the compression API would be useful for debugging, though probably not 100% necessary. What is your use-case for the buffer-less API? Could you use...