teoparvanov

Results 11 comments of teoparvanov

Hi @yontyon, can you please try the following (currently disabled) test with your PR? https://github.com/vmware/concord-bft/blob/master/tests/apollo/test_skvbc_restart_recovery.py#L495 I'd suggest to run it in a loop, as a confirmation that your changes here...

> > > Do we want to merge this in 0.11.x at that stage? @teoparvanov? Hi @dartdart26 and @yontyon, yes, we would merge this, once we: * make sure it...

We are fundamentally reworking the graminization flow in OpenFL 1.7, so I'm closing this issue.

Please sign your commits by running `git commit -s -m "..."`. This will fix the DCO verification failure in the PR pipeline.

Hi @Efrat1, after addressing @MasterSkepticista's comments, I'd request that you additionally test those changes by running a [containerized OpenFL federation](https://openfl.readthedocs.io/en/latest/about/features_index/taskrunner.html#docker-container-approach) locally.

@anshubit5516, a couple of general comments regarding the PR quality: - please provide a more thorough description, including a detailed `Testing` section - could you sign your commit(s) via `git...

Hey @psfoley , thank you for the detailed review! Let me try to address your comments: > * You have logic to create TLS credentials specific to the enclave, but...

Thanks for spotting this and collecting all the relevant logs, @noopurintel! So the issue occurs when you restart all participants, rather than the aggregator individually, right? Have you seen it...

Thanks for clarifying, I think this is a more realistic scenario than all nodes suddenly restarting in a distributed (and even decentralized) setup. While we figure out how to prioritize...