openfl icon indicating copy to clipboard operation
openfl copied to clipboard

Add a disclaimer about ITREX being discontinued

Open rachitchadha opened this issue 7 months ago • 3 comments

Add a disclaimer at top of this notebook that Umbrella repo containing IET and neural-chat (ITREX) has been discontinued

Summary

[Provide a short and descriptive summary of the pull request, e.g., "Improve caching mechanism for API calls"]

Type of Change (Mandatory)

Specify the type of change being made.

  • Feature enhancement
  • Bug fix
  • Documentation update
  • Security improvement
  • Others [Please specify]

Description (Mandatory)

[Explain the goal of this PR, the problem it solves and a summary of changes made. Reference any related issues or tickets (e.g., Fixes #123).]

Testing

[Describe the testing done for this PR. If applicable include screenshots.]

rachitchadha avatar May 22 '25 03:05 rachitchadha

Please sign your commits by running git commit -s -m "...". This will fix the DCO verification failure in the PR pipeline.

teoparvanov avatar May 22 '25 08:05 teoparvanov

If ITREX / Neuralchat libraries are archived, they should be removed from the example. From looking through the notebook I expect it's straightforward to swap in other Huggingface libraries here, but I'll defer to @kta-intel if he has a different recommendation as this is his original example

psfoley avatar May 22 '25 23:05 psfoley

If ITREX / Neuralchat libraries are archived, they should be removed from the example. From looking through the notebook I expect it's straightforward to swap in other Huggingface libraries here, but I'll defer to @kta-intel if he has a different recommendation as this is his original example

Yeah, it should be fairly straightforward to swap ITREX calls with HF Transformer calls, but I actually recommend we remove this example entirely. As it stands, without the ITREX components (which I agree should be removed since they are archived), this example won't add any unique functionalities from the phi-4 fine-tuning example

WDYT? @teoparvanov @rachitchadha

kminhta avatar May 23 '25 14:05 kminhta