Etotaziba Olei

Results 25 comments of Etotaziba Olei

> @teneeto This looks pretty good. Let me know when it's ready for a review 🙇 Hi, @marcaaron this is ready and open for review. The last commits result from...

Ayye! I didn't test for light mode, let me quickly fix those.

Thanks for the brilliant reviews guys. I made a couple of changes. The design should look something like this. https://github.com/Expensify/App/assets/22779249/611d7426-56a1-4b9b-b0dc-e7667071a83e

> Can you help me understand why we are making changes to this particular screen here? ![CleanShot 2024-02-06 at 09 12 03@2x](https://private-user-images.githubusercontent.com/2319350/302657922-7c4cddcc-bd5d-4b8f-acc5-4190b05c62b2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDcyMjkwNTYsIm5iZiI6MTcwNzIyODc1NiwicGF0aCI6Ii8yMzE5MzUwLzMwMjY1NzkyMi03YzRjZGRjYy1iZDVkLTRiOGYtYWNjNS00MTkwYjA1YzYyYjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAyMDZUMTQxMjM2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzMxODQxNmQ5NmNkMDk4ZjUyMDQxZjgyMDFiMjU4N2YyNjY3MWQ1OWQyY2Y0YWU0NTcwOGVmZTU2MTJhNmZjNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.3QnSXyxoWXwbw7OR5MqVgCnZIpsh2mlBBTZ-l2OISC8) > > This already exists in the app...

Hi @shawnborton, Reverted this back as much as possible, no style changes at all, except continuing animation background color up to Status bar and also having flow in navigation rather...

@shawnborton, Sure you have it here. https://github.com/Expensify/App/assets/22779249/e37ae0e7-28bf-4aab-9c69-ce8f59857a63 https://github.com/Expensify/App/assets/22779249/8aa60265-0fa2-4d51-b061-858cf6cf3d9e

> For the Yes/No buttons here: ![CleanShot 2024-02-06 at 14 17 44@2x](https://private-user-images.githubusercontent.com/2319350/302750819-a8c2cc3b-6bac-4d7b-911c-ec36e6ea830b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDcyNDc0MDYsIm5iZiI6MTcwNzI0NzEwNiwicGF0aCI6Ii8yMzE5MzUwLzMwMjc1MDgxOS1hOGMyY2MzYi02YmFjLTRkN2ItOTExYy1lYzM2ZTZlYTgzMGIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAyMDZUMTkxODI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTM2NTlhMWJhN2ZlZDU1YjlkN2RkZDA3NzFhMGM2MjBmMzM3ZTI1YzhhNmM0OGQ5NmZkMjNkMDc5ZDNkYjMzZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.mXO3eJLNySrVXiw23YtBIMqL1oOw4pqt91Up9fdVueE) > > I think we only want 20px of padding from the edge of the view to the...

@shawnborton I'm not sure about the background you mean. are you talking about the app background? if it is, then that is set based on theme, and i currently recorded...

> The bright green area. @marcaaron had a similar comment [here](https://github.com/Expensify/App/pull/35019#issuecomment-1928338643) @shawnborton Please [check](https://github.com/Expensify/App/pull/35019#issuecomment-1930498413) again.

> Everything looks good except the color of the green on this screen. Should be `green-600`: ![CleanShot 2024-02-07 at 06 59 05@2x](https://private-user-images.githubusercontent.com/145416827/302775200-4ac454c4-44b1-4d65-bc62-599f1eb91efa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDcyNTM0OTAsIm5iZiI6MTcwNzI1MzE5MCwicGF0aCI6Ii8xNDU0MTY4MjcvMzAyNzc1MjAwLTRhYzQ1NGM0LTQ0YjEtNGQ2NS1iYzYyLTU5OWYxZWI5MWVmYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwNlQyMDU5NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jNjkwY2FlOWRkZjQwNWE2NGE1NjdlNDQ4MmI1OGRhZjRlNzU5NjMzZGQ3ZTZlNjQ2NWI0Y2EzZmRmYjQyZGNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.1Cizf6R80lzol5ymaf0JjOtIemqbU_tITspsMBbJqDw) > > Otherwise this is wonderful work 🙌...