feat: add additional full screen engagement modal to NewDot

[teneeto]

Details

Adds additional screens - new Engagement Modal that pops up for new users on the site, and sends concierge messages related to their choices.

Fixed Issues

$ Build additional screens for engagement modal #34468 PROPOSAL: issue-2079898524

Tests

New Account

1. Create a new account on NewDot
2. Make sure you see the engagement modal
3. Choose any option
4. Make sure that concierge sends you a message based on that option (on mobile, you should be brought to the concierge chat page)
5. Sign out and back in
6. Make sure the message is still there and that the modal does not re-appear
7. Repeat this for all options

---

Existing Account

1. Log into an account that is on a workspace already
2. Make sure that the modal does not appear

---

Completed on OldDot

1. Create a new account on OldDot
2. Wait for the RHP to pop up
3. Select any option
4. Sign into newDot on the same account
5. Make sure that the modal does not appear

---

Closed on OldDot

1. Create a new account on OldDot
2. Wait for the RHP to pop up
3. Select the x in the top right
4. Sign into newDot on the same account
5. Make sure that the modal does not appear

---

Closed on NewDot

1. Create a new account on NewDot
2. Click the x on the modal
3. Refresh the page
4. Make sure that the modal does not re-appear

• [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/22779249/9c5937e4-012f-4dbc-96a1-61fadc5a5727

Android: mWeb Chrome

https://github.com/Expensify/App/assets/22779249/7f792970-227e-425c-bcce-03472e1e1de4

iOS: Native

https://github.com/Expensify/App/assets/22779249/8c879c11-ae0d-42e3-be50-bbd5eaf10215

iOS: mWeb Safari

https://github.com/Expensify/App/assets/22779249/bb1f06c9-74f0-450d-8f0b-8e3cb30f2e09

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/22779249/6b4ab9ab-3c50-4187-8a05-df2b04b7a5c5

MacOS: Desktop

https://github.com/Expensify/App/assets/22779249/25a123d3-e5ee-407f-bed0-84ee76c002b9

[melvin-bot[bot]]

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[marcaaron]

@teneeto This looks pretty good. Let me know when it's ready for a review 🙇

[teneeto]

@teneeto This looks pretty good. Let me know when it's ready for a review 🙇

Hi, @marcaaron this is ready and open for review. The last commits result from changes I keep making from merge conflicts or file changes in the codebase itself. I'd appreciate an early review, Thanks 🙇.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35019/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35019/NewExpensify.dmg	https://35019.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35019/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35019/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35019/NewExpensify.dmg	https://35019.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[marcaaron]

Gonna post a few design things I'm noticing so far (this is native Android)

(Left is the original mock in dark mode. Right is current branch with light mode)

Mobile web (Android): (Left is existing design)

cc @Expensify/design if anyone has other notes before we ship this one.

[shawnborton]

How does this particular screen happen?

I feel like we shouldn't be touching anything for that, since it already exists and seems to work fine?

[shawnborton]

Otherwise @marcaaron welcome to the design team, you've got quite the 🦅 👁️ !

[dubielzyk-expensify]

@marcaaron nailed it with all the feedback. A few extra callouts:

• [ ] The statusbar should also have the green color here:

• [ ] The illustration here is too tall and should be the same height as the one for the Expensify Classic illustration:

[teneeto]

Ayye! I didn't test for light mode, let me quickly fix those.

[teneeto]

Thanks for the brilliant reviews guys. I made a couple of changes.

The design should look something like this.

https://github.com/Expensify/App/assets/22779249/611d7426-56a1-4b9b-b0dc-e7667071a83e

[shawnborton]

Can you help me understand why we are making changes to this particular screen here?

This already exists in the app and to my knowledge, it works perfectly fine. It also uses a different color BG, etc.

[teneeto]

Can you help me understand why we are making changes to this particular screen here?

This already exists in the app and to my knowledge, it works perfectly fine. It also uses a different color BG, etc.

We had to move that screen to navigation and also use an existing IllustratedHeaderPageLayout, I didn't look at the original design so i guess I've assumed too much on that screen, I will revert in a moment.

[teneeto]

Hi @shawnborton,

Reverted this back as much as possible, no style changes at all, except continuing animation background color up to Status bar and also having flow in navigation rather than modal.

check again and let me know. Thanks!

https://github.com/Expensify/App/assets/22779249/fe907ae5-0312-4707-9eb7-b267120eaec6

https://github.com/Expensify/App/assets/22779249/5abc3ffa-cb23-4830-8bfa-ef82a2e03803

[shawnborton]

Nice, that's feeling better! Can you share what the rest of the flow is feeling like, too? Thanks!

[teneeto]

@shawnborton, Sure you have it here.

https://github.com/Expensify/App/assets/22779249/e37ae0e7-28bf-4aab-9c69-ce8f59857a63

https://github.com/Expensify/App/assets/22779249/8aa60265-0fa2-4d51-b061-858cf6cf3d9e

[shawnborton]

For the Yes/No buttons here:

I think we only want 20px of padding from the edge of the view to the wrapper that houses the buttons. It looks like the padding might be too large right now.

[teneeto]

For the Yes/No buttons here:

I think we only want 20px of padding from the edge of the view to the wrapper that houses the buttons. It looks like the padding might be too large right now.

Thanks @shawnborton

I have updated the horizontal paddings: https://github.com/Expensify/App/pull/35019#issuecomment-1930498413

View the web video.

[shawnborton]

Nice! I think one of the remaining items as well is changing the background color of this area to match the mockup that @dubielzyk-expensify provided:

[teneeto]

@shawnborton I'm not sure about the background you mean. are you talking about the app background? if it is, then that is set based on theme, and i currently recorded on a light theme, that's why.

Is this what you mean?

https://github.com/Expensify/App/assets/22779249/e4c1dcea-0f6f-411b-8eaf-c1612ccf2fad

[shawnborton]

The bright green area. @marcaaron had a similar comment here

[teneeto]

The bright green area. @marcaaron had a similar comment here

@shawnborton Please check again.

[dubielzyk-expensify]

Everything looks good except the color of the green on this screen. Should be green-600:

Otherwise this is wonderful work 🙌

[teneeto]

Everything looks good except the color of the green on this screen. Should be green-600:

Otherwise this is wonderful work 🙌

It's updated already.

[teneeto]

@dubielzyk-expensify check this video again. I updated the mobile record also.

[shawnborton]

Minor thing: area below bottom-docked buttons is inconsistent, the second screenshot is correct I think?

[teneeto]

@shawnborton check one more time.

[shawnborton]

Lovely!

[marcaaron]

Reviewer Checklist

• [x] I have verified the author checklist is complete (all boxes are checked off).
• [x] I verified the correct issue is linked in the ### Fixed Issues section above
• [x] I verified testing steps are clear and they cover the changes made in this PR
  • [x] I verified the steps for local testing are in the Tests section
  • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [x] I checked that screenshots or videos are included for tests on all platforms
• [x] I included screenshots or videos for tests on all platforms
• [x] I verified tests pass on all platforms & I tested again on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [x] I verified proper code patterns were followed (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[marcaaron]

Going to do a quick run through on the testing and should merge by EOD