Börje Karlsson comments

Results 69 comments of


                                            Börje Karlsson

[* DateTimeV2] Support for context for establishing limits in DatePeriod and DateTimeperiod in ExperimentalMode (#640)

@LionbridgeCSII, we'll review this soon. Is the behaviour in this PR now consistent between the default and experimental modes?

[.NET] Implement Regex cache and add option to use Compiled Regex

Thanks for the contribution, @theolivenbaum! But the build is failing. Can you mark this PR as draft for now? We'll start a review and leave comments soon.

[.NET] Implement Regex cache and add option to use Compiled Regex

@theolivenbaum, sorry for the delay to get back to you. I'll try to review this one ASAP. We were blocked by other demands.

[.NET] Implement Regex cache and add option to use Compiled Regex

@theolivenbaum, I've left some initial comments here. Thanks.

[Python | EN DateTimeV2] Fix detection of Monday 21 to match .NET implementation

To be reviewed soon.

[JavaScript] lerna/ava versions old versions causing dependency update issues

Same for node.js dependency. Trying to move from v14.17.6 to v16.13.0 causes all sorts of problems.

[EN DateTimeV2.Timezone] Support recognition of common timezone short names as entity, providing possible alternatives

Current solution under "EnablePreview" doesn't handle ambiguous cases.

[* Number] Percentage recognizer resolution should resolve to fraction

This is lower priority for now. And the initial implementation would need a config flag (or resolution policy) to toggle between the old value representation and the new one.

[* DateTimeV2] DateTimeRanges don't use context as basis for establishing limits

@LionbridgeCSII, please take a stab at it after the newly opened issues. This will probably require bigger changes to solve in a more general way. But it would be great...

[* DateTimeV2] Recognition of "[day] [calendar date] into multiple entities if day doesn't match date

This is a bit tricky. Please let us know your analysis before changing the implementation. There is a common scenario where people make a mistake on the DOW and still...