Results 344 comments of Tee Ming

Alright. So apparently I was importing something from `drizzle/d1` in a typescript file and they've included `/// ` in their type declaration file so the workers types became available globally....

Adding a note here from https://github.com/sveltejs/kit/pull/12088#issuecomment-2156091419 It was suggested to not automatically include the cloudflare types globally because they pollute the ambient types namespace.

> Should this be a bit more generic so that it can be used by other adapters too? or is the way route splitting works so adapter-specific that they all...

added a naive implementation to support Netlify then realised the adapter only supports `split` for normal functions. Couldn't even find an existing issue to add split support for edge functions....

> > don't run reroute again in the split function that comes after the middleware > > The most straight forward solution here would probably be to have a `x-sveltekit-rerouted-from`...

Awesome. What's left is a mention in the vercel and netlify adapter docs and some cleanup for those duplicated edge function generators. Unless it's okay to leave them separate? They...

Two things I'm unsure of: 1. Should this be a be a minor or a patch bump? It is a fix so that `reroute` works correctly with split functions but...

> > Should there be more details added to the documentation? Such as the reason why it needs to be in an edge middleware or that reroute will run twice:...

> > Should this be a be a minor of patch bump? It is a fix so that reroute works correctly with split functions but people should know that they'll...

I've updated the changesets to a minor so that it's more likely people will read it and the new billing impact.