Results 344 comments of Tee Ming

> I wonder if we could drop `routes` from the example. It makes sense to include the directory for URLs like `/about`, but we don't necessarily need it for the...

> > I had this initially too but realised it could break if anyone changed the files.routes config and it no longer points to src/routes. But this should be a...

Another suggestion regarding layout groups: If you had layout groups, your tabs wouldn't give you the context of what route the file if for: ![layout groups only as tab labels...

> Inclusion of the Svelte config was reverted in #11908 because it's a breaking change strictly speaking. Is it ok to hold off from doing this until 3.0? Oh whoops....

note: it was suggested to not include the cloudflare types because they pollute the ambient types namespace.

@benmccann is this a breaking change because of the additional types in the ambient namespace?

Will try to see if this can be alleviated by utilising the Vite environments API.

Thanks! This looks good. I think all we need is a changeset and some documentation on how to get started. The instructions could be similar to the setup in the...

Additionally, the types are missing for the other properties declared by the adapter. `platform.cf` should be typed `IncomingRequestCfProperties` ![CleanShot 2024-01-25 at 2  02 43@2x](https://github.com/sveltejs/kit/assets/54401897/7f51e639-fc57-4ff4-ad8a-5f40a828a2bf) I can get it working if...

Recently, I used TypeScript nightly in VSCode and this wasn't an issue anymore. Maybe I'll need to check again if it was just a fluke or if it also works...