Tee Ming comments

Results 344 comments of


                                            Tee Ming

fix: use resolve_symlinks for node.universal and node.server

Thanks! The repro works well and I've tested the fix with it. Can you add a test for this? Maybe in one of the other test suite folders we could...

feat: enable cwd override for vite plugin

closing as resolved in https://github.com/sveltejs/kit/issues/12499#issuecomment-2320091512

fix: don't error on dynamic routes with `prerender = false`

> Is this only about silencing that exact error? I think it's more about control of whether a route should error if it's not prerendered, which are only some routes...

mutating the `data` prop in a universal load affects the data returned from a server load

Based on https://github.com/sveltejs/kit/issues/13835 we should probably throw a better error message here (and document this?)

fix: correctly handle pathnames found in the `_redirects` file

Thanks, that's a good suggestion. I've added a link to the [_routes.json documentation](https://developers.cloudflare.com/pages/functions/routing/#create-a-_routesjson-file). [`77dc208` (#12821)](https://github.com/sveltejs/kit/pull/12821/commits/77dc20860491d37c936f6ec27380a492b096d392)

fix: correctly handle pathnames found in the `_redirects` file

> Is this still all correct now that there was a breaking change about the other things that no longer are in the `static` directory? Thanks for the reminder. I...

fix: clone server data before running universal load on server

I think the simplest fix for this is to shallow clone the object because: 1. serialising the server data earlier requires awaiting all the server loads and it also messes...

Allow using build.cssCodeSplit option in vite.config

Unfortunately, this isn't so straightforward. I've tried disabling the CSS splitting but it causes the final build to not load any CSS at all. Maybe related to https://github.com/vitejs/vite/issues/1579 where disabling...

fix: support absolute URLs with `data-sveltekit-preload-code="viewport"`

I've fixed the build test that was failing. It involved the newly added test expecting a request URL from the route path instead of the chunk path (which is used...

pushState/replaceState don't trigger beforeNavigate

`pushState` and `replaceState` do not perform an actual navigation (shallow navigation) as it does not change the underlying route. The only things that do change are: * The browser URL....