Josh Nichols

Results 232 comments of Josh Nichols

I think this can be closed now that https://github.com/google/cpu_features/pull/209 merged which makes a similar fix

It took reading the [Regexp documentation](http://ruby-doc.org/core-2.2.0/Regexp.html#class-Regexp-label-Anchors) around anchors and lookahead/behinds, but I found a way to do it. Basically, process markdown and html links first, then use negative lookahead and...

@stevenosloan I'm actually using `Slack::Notifier::LinkFormatter` on its own to format text for a Slack export (ie something that is compatible when you export a team, in order to import it)....

We're looking at Graviton2 instances for CI and production too. Not having a release wouldn't be a blocker for us, but would mean we'd have to build our own.

This would also mirror the newish behavior on pagerduty.com, where you see your incidents first by default.

The default (in most places) is 100 results. This script currently uses `msg.send` for each schedule found which could flood a channel/room/whatever, so that might need to be revisited as...

@danoc I took a look at your fork, and I'm not seeing anything obvious that fixes the issue you reported. I would have guessed that we needed to deal with...

> My solution uses async.map to loop through the schedules, get an array of who is on call messages, and then join that array and only print it once: https://github.com/optimizely/hubot-pager-me/blob/798edc845e24f9e043a7f11c23ab6fb32faa981d/src/scripts/pagerduty.coffee#L35-L37...

Totally agree. This script has grown a lot over time, and could use some cleanups in general. I think it'd be worthwhile to extract the PagerDuty API integration out of...

https://github.com/poetic/nock-vcr-recorder might be useful for testing the API interactions