hubot-pager-me
hubot-pager-me copied to clipboard
Test coverage for commands
This package is getting a bit unwieldy with new commands and lacks spec coverage. As important as it is to a lot of folks using it, it would be worthwhile to investigate getting a mocking layer between the package script and the PagerDuty API so we can run a more robust test suite than "does our regex match?"
@rick has done some pretty solid work with getting a graph-me clone testable. We may be able to borrow some ideas from there: https://github.com/rick/hubot-graphme/blob/master/test/graph-me_test.coffee
Totally agree. This script has grown a lot over time, and could use some cleanups in general. I think it'd be worthwhile to extract the PagerDuty API integration out of this, and then use stubs for testing like you said.
https://github.com/poetic/nock-vcr-recorder might be useful for testing the API interactions