Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

"Add roles" placeholder is missing if the role is deleted or `edit_posts` capability is revoked

Thanks @hussain-t! IB :white_check_mark:

Enhancement/5148 remove zerodatastates feature flag

@makiost there are also some failing E2E tests, please could you take a look at those?

Include a "request access" link to Analytics when a user encounters an "Insufficient Permissions" notice

IB :white_check_mark:

Include a "request access" link to Analytics when a user encounters an "Insufficient Permissions" notice

IB :white_check_mark:

Clicking the Site Kit logo within the header of DashboardEntityApp should redirect user to the main dashboard.

Hi @nfmohit, thanks for the IB. I would suggest a slightly different approach here, though. Rather than providing an `onClick` handler I would just pass the dashboard URL as the...

Clicking the Site Kit logo within the header of DashboardEntityApp should redirect user to the main dashboard.

Hey @nfmohit, thanks for pointing that out. To be honest I don't think we need to be too "smart" about this. If we just use the dashboard URL, when the...

Clicking the Site Kit logo within the header of DashboardEntityApp should redirect user to the main dashboard.

Thanks @nfmohit. LGTM! IB :white_check_mark:

WP dashboard widget show daily uniques

IB :white_check_mark:

Error boundary UI has no space between button and report link

Hi @nfmohit, the IB is looking good. One suggestion: Rather than adding more functionality to `ErrorComponent` while the existing behaviour is unused, how about allowing the existing behaviour of clicking...

Error boundary UI has no space between button and report link

Thanks @nfmohit! IB :white_check_mark: