Enhancement/5148 remove zerodatastates feature flag

[maciejost]

Summary

Addresses issue:

• #5148

Relevant technical choices

Removal of the zeroDataStates-feature flag. All conditionals expecting the flag to be enabled are refactored to just run, the code expecting it to be disabled is removed.

PR Author Checklist

• [ ] My code is tested and passes existing unit tests.
• [ ] My code has an appropriate set of unit tests which all pass.
• [ ] My code is backward-compatible with WordPress 4.7 and PHP 5.6.
• [ ] My code follows the WordPress coding standards.
• [ ] My code has proper inline documentation.
• [ ] I have added a QA Brief on the issue linked above.
• [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• [ ] Run the code.
• [ ] Ensure the acceptance criteria are satisfied.
• [ ] Reassess the implementation with the IB.
• [ ] Ensure no unrelated changes are included.
• [ ] Ensure CI checks pass.
• [ ] Check Storybook where applicable.
• [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

• [ ] Ensure the PR has the correct target branch.
• [ ] Double-check that the PR is okay to be merged.
• [ ] Ensure the corresponding issue has a ZenHub release assigned.
• [ ] Add a changelog message to the issue.

[github-actions[bot]]

Size Change: -10.1 kB (-1%)

Total Size: 1.5 MB

Filename	Size	Change
./dist/assets/js/googlesitekit-activation-********************.js	28.1 kB	+10 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js	36.3 kB	-2.2 kB (-6%)	✅
./dist/assets/js/googlesitekit-api-********************.js	9.25 kB	-8 B (0%)
./dist/assets/js/googlesitekit-dashboard-********************.js	66.6 kB	-1.4 kB (-2%)
./dist/assets/js/googlesitekit-dashboard-details-********************.js	58.9 kB	-1.81 kB (-3%)
./dist/assets/js/googlesitekit-dashboard-splash-********************.js	70.7 kB	+46 B (0%)
./dist/assets/js/googlesitekit-data-********************.js	2.09 kB	+2 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	8.88 kB	-8 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB	+4 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	14.9 kB	+12 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js	8.97 kB	-9 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	30.3 kB	+6 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js	26.1 kB	+13 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	69.3 kB	-749 B (-1%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	19 kB	-136 B (-1%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js	68.2 kB	-1.34 kB (-2%)
./dist/assets/js/googlesitekit-modules-********************.js	19.5 kB	+15 B (0%)
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js	27.6 kB	-468 B (-2%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js	19.5 kB	+1 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	18.5 kB	-13 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	38.5 kB	-1.1 kB (-3%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	32 kB	+295 B (+1%)
./dist/assets/js/googlesitekit-modules-thank-with-google-********************.js	24.7 kB	+262 B (+1%)
./dist/assets/js/googlesitekit-settings-********************.js	50.1 kB	-22 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js	45 kB	+5 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js	323 kB	+31 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js	19.5 kB	-8 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	59.7 kB	-1.55 kB (-3%)
./dist/assets/js/runtime-********************.js	1.34 kB	+1 B (0%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	48.3 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	5.96 kB
./dist/assets/js/31-********************.js	2.8 kB
./dist/assets/js/32-********************.js	2.28 kB
./dist/assets/js/33-********************.js	3.72 kB
./dist/assets/js/34-********************.js	51.9 kB
./dist/assets/js/35-********************.js	16.1 kB
./dist/assets/js/36-********************.js	70.9 kB
./dist/assets/js/37-********************.js	31.6 kB
./dist/assets/js/38-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	769 B
./dist/assets/js/googlesitekit-base-********************.js	1.13 kB
./dist/assets/js/googlesitekit-i18n-********************.js	3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js	45.1 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	378 B

_{compressed-size-action}

[techanvil]

@makiost there are also some failing E2E tests, please could you take a look at those?