Tom Rees-Herdman
Tom Rees-Herdman
Thanks @jimmymadon - the wording is good, to specify checking specifically for false. However, the code example is still not actually doing that - it's only checking for a truthy...
Thanks @jimmymadon! IB :white_check_mark:
@jimmymadon @aaemnnosttv thanks for the explanation here, I guess it does make sense to leave it without the default then...
> Thank you so much for clearing this, @tofumatt! > > I did some more thorough reading and observation of the Design Docs and the Figma designs, and I think...
Hi @nfmohit, apologies as I had thought this PR was good to go. However I subsequently realised the case where an existing property _does_ exist also needs to be covered...
> > In `assets/js/modules/thank-with-google/components/dashboard/ActivationBanner/SetupBanner.js`: > > @techanvil I believe this file should belong to the `analytics-4` module, shouldn't it? Whooops, that was a copy/paste error. I've fixed it - thanks...
Hey @nfmohit, thanks for the tag. 1. Actually, I do think we need to reduce the font size for the title here. Notice that in Figma, the font size for...
Adding a note to mention that the IB and subsequent implementation was a bit wrong here and we should have been checking the result of the `analytics-4` `getProperties` selector to...
IB :white_check_mark:
Hey @jimmymadon, the IB is looking good. A couple of minor typo-looking points - - In the 2nd point, "Tagmanager Account" should be "Tag Manager account". - In the 3rd...