Tom Rees-Herdman

Hey @felixarntz, that sounds good to me. However, something else has occurred to me, which is that we'd be relying on following a pattern, which has the potential to go...

Thanks @felixarntz - sounds sensible enough to me. I've added an issue to address this, building on your initial set of bullet points: https://github.com/google/site-kit-wp/issues/5618.

Code looks good but this issue is dependant on #5618 in order to be functionally testable, as such is on hold until that issue has been implemented. @makiost, I'll assign...

Hi @eugene-manuilov, I am not aware of any out-of-the-box or trivial way to blanket exclude this rule for functional components. The approach I would take here would be to introduce...

Hey @aaemnnosttv, that sounds like a sensible approach to me, there's no obvious "right" value at present so iterating on it as you suggest seems like it would allow us...

Thanks @aaemnnosttv, I have added ACs for this one, please take a look. Cc @felixarntz

> @techanvil LGTM although let's also require that issue(s) are opened to address the areas where we've disabled the rule so these are not left ignored. Depending on the scope,...

Thanks @aaemnnosttv, that makes sense. I have updated the AC to remove the attempt to identify the followup threshold.

Good spot there @aaemnnosttv. I have looked into this and it's not a regression as I can see the same behaviour in the previous release. I've created a followup issue...

Thanks @aaemnnosttv, I have taken another look at this, keen to move it along. I tried your suggestion of running `jest.runAllTimers()` in an `afterEach`, but it wasn't very successful, I...