Tony DiCola

startotg.service references wrong path, fails to start

4

Thanks for making this project, it looks really neat! One little thing though, it looks like the startotg.service file has a small bug in this line: https://github.com/tomhartley/piShift/blob/master/startotg.service#L8 It's referencing the...

netconnectcli strips out curly braces and commas from JSON result

1

I'm not sure if this is by design but it appears netconnectcli returns JSON results that are missing the curly braces and commas. I think from the readme it's supposed...

Handle no BLE adapter exception on windows

4

Noble throws an error when no BLE adapter is present on windows. Catch this and display the loading error page. 

Refactor main.js to reduce complexity.

1

The program logic/complexity has started to grow large enough that there needs to be a clean separation between internal program state (like the list of devices, selected device, known services,...

See the example linked from this issue on the GFX library: https://github.com/adafruit/Adafruit-GFX-Library/issues/15 This would be handy to merge into the ST7735 library examples.

Consider adding UART mode support

2

This is a todo to add UART mode support to the library. See section 4.7 of the datasheet for the details, it's just a simple I2C framing protocol over a...

ESP8266 compatibility

2

Need to tweak the library slightly to use the right calloc function (appears to be mem_calloc on the ESP8266).

Optimize debounce logic

1

Some good optimizations suggested here that should be integrated: http://forums.adafruit.com/viewtopic.php?f=19&t=56887&p=288441#p288441