startotg.service references wrong path, fails to start

[tdicola]

Thanks for making this project, it looks really neat! One little thing though, it looks like the startotg.service file has a small bug in this line: https://github.com/tomhartley/piShift/blob/master/startotg.service#L8 It's referencing the path /home/pi/programs/startmod.sh but the instructions mention to just put startmod.sh in the /home/pi/piShift folder. I think you want to be consistent with the current instructions and reference the /home/pi/piShift location for startmod.sh. Unfortunately the current startotg.service file won't run as is if you follow the instructions, instead it fails with a 200 CHDIR error because it can't find the startmod.sh script (easy to fix by updating the startotg.service though).

[tomhartley]

Thanks so much for this issue! Whilst I hadn't explicitly noticed it, I think that this is fixed in the rewrite branch, but I haven't had a chance to merge that into master yet. That branch also has the advantage of an install.sh script so you don't have to go through quite as much trouble to install it :)

[carlosperate]

That sounds awesome, any idea when you might be able to merge that into master? (no rush though)

[tomhartley]

Not sure, kinda drowning in exams right now. But feel free to try it - if anything, it's more stable than master!

[carlosperate]

I'll see if I can find some time to give it a go, I quite like the idea of the project.