Thomas Dent comments

Results 47 comments of


                                            Thomas Dent

Some PyCBC Offline jobs are still using too much memory

OK, can you check if the list of codes involved should be shortened

Add any provided key to `lal_pars` for waveform generation

FWIW, the redundant looking InsertMass1 (etc) functions are part of the 'New Waveform Interface', see here https://git.ligo.org/lscsoft/lalsuite/-/commit/5dec1651a0f28879ba5a2f7015744300935f3839?page=2

Add any provided key to `lal_pars` for waveform generation

So the 'key' here is actually the last part of the SimInspiralInsert function name, rather than the LALDict key name itself, if I've understood correctly. I guess this is an...

pycbc_fit_sngl_trigs looks to have been abandoned, should we get rid of it?

Is there any functionality that is not available in other code (presumably fit sngls split binned) ? Eg the KS test?

pycbc_fit_sngl_trigs looks to have been abandoned, should we get rid of it?

Ah, there is also the possibility to save fit coeff values and associated numbers to a txt file via --output .. I guess this could be made available simply in...

Avoid repeated FAR/IFAR conversions

These are two separate questions, but maybe worth considering/fixing at the same time. My initial thoughts on this are that IFAR is a nicer variable to use internally, as it's...

PyCBC Live can still create invalid SNR timeseries in the LIGOLW files

Checking if this is still open

PyCBC live results should record when followup p-value was used and trials factors

@titodalcanton any further thoughts on this?

PyCBC live results should record when followup p-value was used and trials factors

It is only critical / interesting when we are using >2 ifos for significance ...

Retire some codes/modules

FWIW if one has planned a workflow without using --submit-now, how should it be submitted? (Apart from 'later')