pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

pycbc_fit_sngl_trigs looks to have been abandoned, should we get rid of it?

Open GarethCabournDavies opened this issue 2 years ago • 3 comments

The code pycbc_fit_sngl_trigs hasn't been touched in years outwith find/replace style PRs and looks like it has been abandoned.

It isn't used in the github CI, or in any other use cases I know of. Should this be removed?

Assigning to @tdent as he is named in the copyright.

GarethCabournDavies avatar Dec 15 '23 16:12 GarethCabournDavies

Is there any functionality that is not available in other code (presumably fit sngls split binned) ? Eg the KS test?

tdent avatar Dec 17 '23 20:12 tdent

The KS test and the plotting including errors are not in pycbc_fit_sngls_split_binned, but are in pycbc_fit_sngls_binned

GarethCabournDavies avatar Dec 18 '23 08:12 GarethCabournDavies

Ah, there is also the possibility to save fit coeff values and associated numbers to a txt file via --output .. I guess this could be made available simply in fit_sngls_binned by printing the fit values to stdout / logging (then someone can redirect to a file if wanted)

tdent avatar Dec 18 '23 13:12 tdent