pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

Retire some codes/modules

Open GarethCabournDavies opened this issue 9 months ago • 6 comments

We currently have 221 (find bin -name "pycbc_*" | wc) executables stored under bin.

e.g straight away I see pycbc_combine_statmap (superseded by pycbc_add_statmap)

For a while we have mooted retiring pycbc_submit_dax. Should we bite the bullet on that?

We can probably retire some of them at least

We can also probably do some pruning of modules which aren't being used

GarethCabournDavies avatar Mar 14 '25 14:03 GarethCabournDavies

@GarethCabournDavies Yes, remove pycbc_submit_dax has my vote.

ahnitz avatar Mar 14 '25 14:03 ahnitz

Yeah, time to remove submit_dax.

spxiwh avatar Mar 14 '25 14:03 spxiwh

FWIW if one has planned a workflow without using --submit-now, how should it be submitted? (Apart from 'later')

tdent avatar Mar 17 '25 15:03 tdent

Dropping submit_dax probably requires https://github.com/gwastro/pycbc/pull/4945. Nobody as looked at that so far.

titodalcanton avatar Mar 17 '25 16:03 titodalcanton

#4945 was held until we were ready to do this, it should be merged into here (keeping credit for commits), but not including the mac-specific change.

As part of this the --plan-now option should be removed, and is always set to True if submit-now is not given. This means that the workflow is always planned when being generated, but is not submitted unless submit-now is given. Then someone would just do ./start to start the workflow later.

spxiwh avatar Mar 17 '25 16:03 spxiwh

@spxiwh We'll have @alishahassan update the PR with those changes.

ahnitz avatar Mar 17 '25 22:03 ahnitz