Teodor-Dumitru Ene

I would say that the correct way to look at it is that ANTENNADIFFAREA is defined for pins that are connected to diffusion. Typically that is only output pins, as...

To emphasize, the current tech-lef files do not meet the official LEF/DEF guidelines because of this issue.

I believe this is caused by [https://github.com/google/skywater-pdk/issues/358](https://github.com/google/skywater-pdk/issues/358)

> Maybe you can add your own `set ::env(HOLD_FIX_ENABLE) 1` This is part of the reason I came here with this question. If there is interest, I can certainly make...

Thanks @donn. I'd argue this is not a "bug" label, but rather an "enhancement" label :) Would you like a PR like the one @vijayank88 suggested, introducing a new `HOLD_FIX_ENABLE`...

That is a very fair point @maliberty . I'll have to jump back into those runs and dig out some data. I most definitely had `dlygate`s inserted into my clock-less...

> Is it fine & really required to introduce extra param --input_tokenizer? I'm modeling this off #8000. In both cases, the problem is that the converter tries to use the...

Scope or not, there's no point to porting over FastChat's Python controller implementation, it's literally 1000x slower at scale than 1 day's worth of Rust code.

@leiwen83 I apologize, I did not mean to be rude. The idea is good, this type of controller is very useful. But I have seen first-hand how incredibly slow FastAPI...

[sampling_params imports sequence_controller](https://github.com/mmoskal/vllm/blob/seq_controller/vllm/sampling_params.py#L11) [sequence_controller imports sequence](https://github.com/mmoskal/vllm/blob/seq_controller/vllm/sequence_controller.py#L3) [sequence imports both sampling_params and sequence_controller](https://github.com/mmoskal/vllm/blob/seq_controller/vllm/sequence.py#L11) Leading to Python circular import errors. Applying [PEP484](https://peps.python.org/pep-0484/#forward-references) to `sequence_controller.py` is a possible way to patch this.