Thomas Coratger
Thomas Coratger
## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. -...
## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. -...
As a followup of https://github.com/xJonathanLEI/starknet-rs/pull/598 we should add a warn on this clippy lint https://rust-lang.github.io/rust-clippy/master/#/needless_pass_by_value?groups=nursery,pedantic > Taking arguments by reference is more flexible and can sometimes avoid unnecessary allocations.
The following Poseidon implementation https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-crypto/src/poseidon_hash.rs should be replaced by the dedicated `type-rs` provided implementation: https://github.com/starknet-io/types-rs/blob/main/crates/starknet-types-core/src/hash/poseidon.rs
The following Pedersen implementation https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-crypto/src/pedersen_hash.rs should be replaced by the dedicated `type-rs` provided implementation: https://github.com/starknet-io/types-rs/blob/main/crates/starknet-types-core/src/hash/pedersen.rs
At the moment, we have multiple `TransactionStatus` enum variants around the codebase: https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-core/src/types/mod.rs#L178-L183 https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-core/src/types/codegen.rs#L1536-L1545 https://github.com/xJonathanLEI/starknet-rs/blob/4dbc1692d4f295de803484181e07803201528922/starknet-providers/src/sequencer/models/transaction_receipt.rs#L35-L51 I think this should be unified, probably in core to have a single variant for...
### Extend JSON-RPC Transport Capabilities for Batch Requests #### Context Currently, the `JsonRpcRequest` structure in https://github.com/xJonathanLEI/starknet-rs/blob/master/starknet-providers/src/jsonrpc/transports/http.rs allows for making JSON-RPC requests with a specified method. To support the needs of...
In order for the codebase to be more Rust idiomatic and to improve some part/performance, we could enforce more clippy lint rules at a root level. See for example what...
In circumstances like [cairo_native](https://github.com/lambdaclass/cairo_native), and other projects working on Cairo and its compilation, it is extremely useful to have a `Debug` implementation for each public structure and enum. Therefore, the...